Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos #1187

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Typos #1187

merged 1 commit into from
Oct 22, 2021

Conversation

markstrefford
Copy link
Contributor

@markstrefford markstrefford commented Oct 22, 2021 •
edited
Loading

Fixed a couple of typos in hello world tutorial

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

joshuahannan
joshuahannan approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing these!

@SupunS SupunS added the Documentation Improvements or additions to documentation label Oct 22, 2021
turbolent
turbolent approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turbolent turbolent merged commit aa8f2d6 into onflow:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@joshuahannan joshuahannan joshuahannan approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markstrefford @turbolent @joshuahannan @SupunS