Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tracing to interpreter #1179

Merged
merged 22 commits into from
Nov 5, 2021
Merged

Conversation

ramtinms
Copy link
Member

@ramtinms ramtinms commented Oct 18, 2021

Description

This PR

  • adds tracing functionality to the runtime and interpreter
  • adds a flag to the interpreter to avoid any extra operations for tracing
  • redirects tracing to the runtime interface to be captured by flow-go tracer
  • implements few tracing utils for cadence methods, deep copy of array and dictionary, ... it would be expanded in follow up PRs.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@ramtinms ramtinms changed the base branch from master to bastian/atree-5 October 18, 2021 18:53
@ramtinms ramtinms changed the title [WIP] Ramtin/adding invocation tracing adding tracing to interpreter Oct 18, 2021
@ramtinms ramtinms marked this pull request as ready for review October 18, 2021 21:12
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll update / resolve conflicts

runtime/runtime.go Outdated Show resolved Hide resolved
Base automatically changed from bastian/atree-5 to master November 2, 2021 11:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #1179 (801a5e0) into master (68cf983) will decrease coverage by 0.09%.
The diff coverage is 15.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   77.12%   77.03%   -0.10%     
==========================================
  Files         272      273       +1     
  Lines       33910    33962      +52     
==========================================
+ Hits        26154    26163       +9     
- Misses       6693     6732      +39     
- Partials     1063     1067       +4     
Flag Coverage Δ
unittests 77.03% <15.68%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/interpreter_expression.go 91.23% <0.00%> (-1.04%) ⬇️
runtime/interpreter/interpreter_import.go 81.48% <0.00%> (-18.52%) ⬇️
runtime/interpreter/interpreter_tracing.go 0.00% <0.00%> (ø)
runtime/interpreter/value.go 82.14% <0.00%> (-0.19%) ⬇️
runtime/runtime.go 86.81% <0.00%> (-0.25%) ⬇️
runtime/interpreter/interpreter.go 87.98% <100.00%> (+0.06%) ⬆️
runtime/common/address.go 92.30% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cf983...801a5e0. Read the comment docs.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! 👌

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent merged commit b947b91 into master Nov 5, 2021
@turbolent turbolent deleted the ramtin/adding-invocation-tracing branch November 5, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants