Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider constant-sized type's size when checking dynamic array type #1158

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Consider constant-sized type's size when checking dynamic array type #1158

merged 1 commit into from
Oct 5, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS October 1, 2021 21:22
@turbolent turbolent self-assigned this Oct 1, 2021
SupunS
SupunS approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

runtime/convertValues_test.go Show resolved Hide resolved
@turbolent turbolent merged commit 57c7254 into master Oct 5, 2021
@turbolent turbolent deleted the bastian/validate-constant-sized-array-import branch October 5, 2021 16:33
This was referenced Oct 5, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS