-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the maps in the type file to simple arrays #1086
Conversation
This changeset will convert the maps of types to simple arrays for performance reasons.
added some more defensive coding pieces
this has some changes from Bastian's WIP branch.
@jwinkler2083233 Can you please give this a proper title and make sure the remaining items are done? |
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
=======================================
Coverage 75.42% 75.42%
=======================================
Files 270 270
Lines 33181 33182 +1
=======================================
+ Hits 25028 25029 +1
Misses 7017 7017
Partials 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
I ran an additional performance check after removing the items from the init() function. All is well on the performance front. Observation of expensive parsing methods is reduced dramatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #1079
Description
This makes some changes to the 'map' objects in type.go, so that they are just simple arrays.
master
branchFiles changed
in the Github PR explorer