Convert the maps in the type file to simple arrays #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 21, 2021 23:01
This changeset will convert the maps of types to simple arrays for performance reasons.
added some more defensive coding pieces
this has some changes from Bastian's WIP branch.
|
@jwinkler2083233 Can you please give this a proper title and make sure the remaining items are done? |
turbolent
reviewed
Jul 22, 2021
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
=======================================
Coverage 75.42% 75.42%
=======================================
Files 270 270
Lines 33181 33182 +1
=======================================
+ Hits 25028 25029 +1
Misses 7017 7017
Partials 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jwinkler2083233
changed the title
turbolent
reviewed
Jul 23, 2021
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
|
I ran an additional performance check after removing the items from the init() function. All is well on the performance front. Observation of expensive parsing methods is reduced dramatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1079
Description
This makes some changes to the 'map' objects in type.go, so that they are just simple arrays.
masterbranchFiles changedin the Github PR explorer