Check member reads and writes #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
force-pushed
the
bastian/check-invocation-receiver
branch
from
319fe62
to
310c031
Compare
turbolent
force-pushed
the
bastian/check-field-access
branch
from
353879e
to
58d8a37
Compare
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 73.53% 73.54% +0.01%
==========================================
Files 272 272
Lines 34458 34499 +41
==========================================
+ Hits 25340 25374 +34
- Misses 7957 7965 +8
+ Partials 1161 1160 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@SupunS this is now mergable, could you please have a look? |
…ction type and constructor flag
Use of an interface directly as a type is already rejected and leads to an InvalidInterfaceTypeError being reported. The subtyping rule of composite types being subtypes of interface types is needed for dynamic type checks
turbolent
force-pushed
the
bastian/check-field-access
branch
from
ed529f8
to
84687e0
Compare
|
@SupunS rebased on |
SupunS
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of dapperlabs/cadence-internal#26
masterbranchFiles changedin the Github PR explorer