-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check member reads and writes #1085
Conversation
319fe62
to
310c031
Compare
353879e
to
58d8a37
Compare
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 73.53% 73.54% +0.01%
==========================================
Files 272 272
Lines 34458 34499 +41
==========================================
+ Hits 25340 25374 +34
- Misses 7957 7965 +8
+ Partials 1161 1160 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@SupunS this is now mergable, could you please have a look? |
…ction type and constructor flag
Use of an interface directly as a type is already rejected and leads to an InvalidInterfaceTypeError being reported. The subtyping rule of composite types being subtypes of interface types is needed for dynamic type checks
ed529f8
to
84687e0
Compare
@SupunS rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly compared with the original PR and checked the new changes. Looks good to me! 👍
Description
Port of dapperlabs/cadence-internal#26
master
branchFiles changed
in the Github PR explorer