Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpretation of optional binding with second value #1082

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

turbolent
Copy link
Member

Description

Port of dapperlabs/cadence-internal#25


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS July 22, 2021 22:19
@turbolent turbolent self-assigned this Jul 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1082 (35c7aa6) into master (cd7a7a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   75.42%   75.43%           
=======================================
  Files         270      270           
  Lines       33181    33191   +10     
=======================================
+ Hits        25028    25038   +10     
  Misses       7017     7017           
  Partials     1136     1136           
Flag Coverage Δ
unittests 75.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/interpreter_statement.go 89.69% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7a7a4...35c7aa6. Read the comment docs.

@turbolent turbolent merged commit 72d0568 into master Jul 29, 2021
@turbolent turbolent deleted the bastian/fix-optional-binding-second-value branch July 29, 2021 03:21
bors bot added a commit to onflow/flow-go that referenced this pull request Aug 18, 2021
1055: Auto Cadence Update: Fix interpretation of optional binding with second value r=turbolent a=turbolent

Auto generated PR to update Cadence version.

References: onflow/cadence#1082

Co-authored-by: turbolent <turbolent@users.noreply.github.com>
Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants