Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for imported array/dictionary value type conformance #1045

Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jul 2, 2021

Work towards #870

Description

Add more tests to check the type conformance of imported nested arrays/dictionaries.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS requested a review from turbolent as a code owner July 2, 2021 08:14
@codecov-commenter
Copy link

Codecov Report

Merging #1045 (1503e7e) into feature/container-static-types (3cfe0f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feature/container-static-types    #1045   +/-   ##
===============================================================
  Coverage                           73.47%   73.47%           
===============================================================
  Files                                 271      271           
  Lines                               34003    34003           
===============================================================
  Hits                                24984    24984           
  Misses                               7882     7882           
  Partials                             1137     1137           
Flag Coverage Δ
unittests 73.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfe0f1...1503e7e. Read the comment docs.

@SupunS SupunS self-assigned this Jul 2, 2021
@SupunS SupunS added the Testing label Jul 2, 2021
@SupunS SupunS merged commit 8ec25b6 into feature/container-static-types Jul 5, 2021
@SupunS SupunS deleted the supun/dynamic-type-conformance branch July 5, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants