Include and consider static types of arrays and dictionaries #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Base automatically changed from
bastian/container-value-import-type-inference
to
feature/container-static-types
July 2, 2021 04:28
SupunS
approved these changes
Jul 2, 2021
| @@ -119,8 +120,14 @@ func (t CompositeDynamicType) IsImportable() bool { | |||
|
|
|||
| // DictionaryDynamicType | |||
|
|
|||
| type DictionaryStaticTypeEntry struct { | |||
There was a problem hiding this comment.
Suggested change
| type DictionaryStaticTypeEntry struct { | |
| type DictionaryDynamicTypeEntry struct { |
Comment on lines
+2687
to
+2690
| subTypeStaticType := interpreter.ConvertStaticToSemaType(typedSubType.StaticType) | ||
| if !sema.IsSubType(subTypeStaticType, typedSuperType) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Once the runtime mutability checks (checking the type of array/dictionary before insertions) are added, I think we can rely only on this check, and maybe don't need to check both the static type and the dynamic type. Because that 'mutability checks on insertions' ensures that any value within the container is a subtype of the static type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #870
Description
masterbranchFiles changedin the Github PR explorer