Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly declare base values in activation without interpreter #1022

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jun 18, 2021

Description

The declaration of the base values does not depend on an interpreter, so refactor the declaration of the base values to be directly performed on the base activation.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS June 18, 2021 23:43
@turbolent turbolent self-assigned this Jun 18, 2021
Base automatically changed from supun/reuse-base-interpreter to master June 19, 2021 04:04
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I was tempted to do the same 😄, but wasn't sure whether the interpreter would be useful later on. So I let it be.
But this makes it simple 👌

@turbolent turbolent force-pushed the bastian/reuse-base-interpreter branch from cedf07e to 378a3a2 Compare June 19, 2021 05:45
@codecov-commenter
Copy link

Codecov Report

Merging #1022 (378a3a2) into master (d5356c1) will increase coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
+ Coverage   75.52%   75.53%   +0.01%     
==========================================
  Files         267      268       +1     
  Lines       32992    32974      -18     
==========================================
- Hits        24918    24908      -10     
+ Misses       6947     6942       -5     
+ Partials     1127     1124       -3     
Flag Coverage Δ
unittests 75.53% <81.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/globalvariables.go 60.00% <60.00%> (ø)
runtime/interpreter/interpreter.go 90.96% <90.90%> (+0.91%) ⬆️
runtime/interpreter/variable_activations.go 75.55% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5356c1...378a3a2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants