Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm generation for docgen tool #1005

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Add wasm generation for docgen tool #1005

merged 3 commits into from
Jun 15, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 13, 2021

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Feature label Jun 13, 2021
@SupunS SupunS self-assigned this Jun 13, 2021
@SupunS SupunS requested a review from turbolent as a code owner June 13, 2021 13:43
@turbolent
Copy link
Member

😍

turbolent
turbolent approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We should also create and publish an NPM package for it, see npm-packages, e.g. just like for the parser

Base automatically changed from supun/docgen-embed-templates to master June 15, 2021 03:01
@SupunS
Copy link
Member Author

SupunS commented Jun 15, 2021

@turbolent Added the NPM package in separate PR: #1008

@turbolent
Copy link
Member

@SupunS Thanks for adding the PR!

@turbolent turbolent merged commit 31e4669 into master Jun 15, 2021
@turbolent turbolent deleted the supun/docgen-wasm branch June 15, 2021 16:29
@turbolent turbolent mentioned this pull request Jun 15, 2021
Closed
@SupunS SupunS mentioned this pull request Jul 9, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@SupunS SupunS

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SupunS @turbolent