Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the result declaration kind #1001

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

turbolent
Copy link
Member

Description

The result declaration kind is not needed anymore after #905


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #1001 (f300271) into master (3141dd5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   75.55%   75.54%   -0.01%     
==========================================
  Files         267      267              
  Lines       32852    32848       -4     
==========================================
- Hits        24820    24816       -4     
  Misses       6905     6905              
  Partials     1127     1127              
Flag Coverage Δ
unittests 75.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/common/declarationkind.go 75.96% <ø> (+0.96%) ⬆️
runtime/common/declarationkind_string.go 33.33% <ø> (ø)
runtime/sema/checker.go 90.00% <ø> (-0.01%) ⬇️
runtime/sema/check_function.go 99.54% <100.00%> (ø)
runtime/ast/transaction_declaration.go 57.89% <0.00%> (-6.82%) ⬇️
runtime/interpreter/decode.go 48.64% <0.00%> (-0.10%) ⬇️
runtime/interpreter/value.go 77.44% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3141dd5...f300271. Read the comment docs.

@turbolent turbolent merged commit 85201f9 into master Jun 12, 2021
@turbolent turbolent deleted the bastian/remove-result-declaration-kind branch June 12, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants