Skip to content

Optimize encoding for remaining types still using CBOR map #764

Closed

Description

Issue To Be Solved

The encoding of 12 types to CBOR values can be optimized.

Suggestion

Switch from CBOR map to CBOR array for:

  • StorageReferenceValue
  • PathValue
  • CapabilityValue
  • common.AddressLocation
  • LinkValue
  • CompositeStaticType
  • InterfaceStaticType
  • ConstantSizedStaticType
  • ReferenceStaticType
  • DictionaryStaticType
  • RestrictedStaticType
  • TypeValue

Definition of Done

  • Optimize encoding
  • Change decoding to only support this current format (i.e. remove old backwards-compatibility decoding code)
    Tests
  • Encode new format
  • Decode new format
  • Decode old format, incl. round-trip, i.e. encoding should match new encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions