Skip to content

Commit

Permalink
Resolve TODOs related to static types for deferred values
Browse files Browse the repository at this point in the history
  • Loading branch information
SupunS committed Aug 24, 2021
1 parent 412b5f7 commit 5b2c6ce
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions runtime/interpreter/value.go
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,11 @@ func NewDeferredArrayValue(
callback DecodingCallback,
version uint16,
) *ArrayValue {

// Note: static type for deferred arrays gets populated when the meta info is loaded.
// i.e: at `ensureMetaInfoLoaded()` method

return &ArrayValue{
// TODO: type
Type: nil,
valuePath: path,
content: content,
Owner: owner,
Expand Down Expand Up @@ -7431,9 +7433,11 @@ func NewDeferredDictionaryValue(
decodeCallback DecodingCallback,
version uint16,
) *DictionaryValue {

// Note: static type for deferred dictionaries gets populated when the meta info is loaded.
// i.e: at `ensureMetaInfoLoaded()` method

return &DictionaryValue{
// TODO: type
Type: DictionaryStaticType{},
Owner: owner,
deferredOwner: owner,
modified: false,
Expand Down

0 comments on commit 5b2c6ce

Please sign in to comment.