Skip to content

perf: optimize pending queue lookup from O(n) to O(1) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liobrasil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: optimize pending queue lookup from O(n) to O(1) #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cadence/contracts/FlowYieldVaultsSchedulerRegistry.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ access(all) contract FlowYieldVaultsSchedulerRegistry {
return self.pendingQueue.keys
}

/// Check if a yield vault ID is in the pending queue - O(1) lookup
access(all) view fun isPending(yieldVaultID: UInt64): Bool {
return self.pendingQueue.containsKey(yieldVaultID)
}

/// Get paginated pending yield vault IDs
/// @param page: The page number (0-indexed)
/// @param size: The page size (defaults to MAX_BATCH_SIZE if nil)
Expand Down
4 changes: 1 addition & 3 deletions cadence/contracts/FlowYieldVaultsSchedulerV1.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,7 @@ access(all) contract FlowYieldVaultsSchedulerV1 {
scanned = scanned + 1

// Skip if already in pending queue
// TODO: This is extremely inefficient - accessing from mapping is preferrable to iterating over
// an array
if FlowYieldVaultsSchedulerRegistry.getPendingYieldVaultIDs().contains(yieldVaultID) {
if FlowYieldVaultsSchedulerRegistry.isPending(yieldVaultID: yieldVaultID) {
continue
}

Expand Down
Loading