Skip to content

S5 General Improvements #115

@nialexsan

Description

@nialexsan

Description:

  1. In ERC4626PriceOracles in the init() function, the verification for assetEVMAddress has already been
    assured by a previous assert statement, and the value could be cached.
  2. In ERC4626SinkConnectors , the _call function is never called with dry = true , therefore the function can be simplified.
    Further, the natspec is inaccurately assertaining that only drycalls are done.
  3. In EVMNativeFLOWConnectors.Sink , the typechecks in depositCapacity() are already guaranteed by the inherited
    preconditions.
  4. In EVMTokenConnectors.Sink , the typechecks in depositCapacity() are already guaranteed by the inherited
    preconditions.
  5. In UniswapV3SwapConnectors.Swapper , the getPoolAddress() function always returns the pool for the first hop in the
    default direction. If the swapper contains a multi-hop path, this may be misleading. Adapt the function to accept a hopIndex
    and reverse flag.

Metadata

Metadata

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions