-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Description:
- In ERC4626PriceOracles in the init() function, the verification for assetEVMAddress has already been
assured by a previous assert statement, and the value could be cached. - In ERC4626SinkConnectors , the _call function is never called with dry = true , therefore the function can be simplified.
Further, the natspec is inaccurately assertaining that only drycalls are done. - In EVMNativeFLOWConnectors.Sink , the typechecks in depositCapacity() are already guaranteed by the inherited
preconditions. - In EVMTokenConnectors.Sink , the typechecks in depositCapacity() are already guaranteed by the inherited
preconditions. - In UniswapV3SwapConnectors.Swapper , the getPoolAddress() function always returns the pool for the first hop in the
default direction. If the swapper contains a multi-hop path, this may be misleading. Adapt the function to accept a hopIndex
and reverse flag.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels