-
Notifications
You must be signed in to change notification settings - Fork 3
Description
File(s) affected: cadence/contracts/connectors/evm/ERC4626SwapConnectors.cdc ,
cadence/contracts/connectors/evm/ERC4626SinkConnectors.cdc
Description: Several TODO comments remain in the codebase indicating incomplete implementations:
- ERC4626SwapConnectors.cdc:204 - "Impl detail - accept quote that was just used by swap() but reverse the direction..."
- ERC4626SinkConnectors.cdc:72 - "Update EVMTokenConnector.Sink to return 0.0 if it doesn't have fees to pay..."
- ERC4626SinkConnectors.cdc:92 - "pass from through and skip the intermediary withdrawal"
- ERC4626SinkConnectors.cdc:118 - "consider more graceful handling of this error"
- ERC4626SinkConnectors.cdc:131 - "Consider unwinding the deposit & returning to the from vault"
Recommendation: Address or explicitly defer all TODOs before production deployment.
Reactions are currently unavailable