Skip to content

FLOW-15 Unfinished TODOs #110

@nialexsan

Description

@nialexsan

File(s) affected: cadence/contracts/connectors/evm/ERC4626SwapConnectors.cdc ,
cadence/contracts/connectors/evm/ERC4626SinkConnectors.cdc
Description: Several TODO comments remain in the codebase indicating incomplete implementations:

  1. ERC4626SwapConnectors.cdc:204 - "Impl detail - accept quote that was just used by swap() but reverse the direction..."
  2. ERC4626SinkConnectors.cdc:72 - "Update EVMTokenConnector.Sink to return 0.0 if it doesn't have fees to pay..."
  3. ERC4626SinkConnectors.cdc:92 - "pass from through and skip the intermediary withdrawal"
  4. ERC4626SinkConnectors.cdc:118 - "consider more graceful handling of this error"
  5. ERC4626SinkConnectors.cdc:131 - "Consider unwinding the deposit & returning to the from vault"
    Recommendation: Address or explicitly defer all TODOs before production deployment.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions