Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Closed
|
|
||
| /// Simulates the withdrawable amount of `type` if the position were fully rebalanced (liquidation scenario). | ||
| /// Returns the amount in units of `type`. | ||
| access(all) fun simulateCloseoutWithdrawalAmount(pid: UInt64, type: Type): UFix64 { |
Contributor
There was a problem hiding this comment.
Does this need to be integrated into the pool's withdrawal path? It's not clear to me how the checks within the withdrawAndPull method pass without also risking withdrawals exceed their health limits on standard withdrawals
Contributor
|
@nialexsan does this still need review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connected PR:
onflow/FlowActions#28