Skip to content

Feature/config plugin #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/config plugin #74

wants to merge 4 commits into from

Conversation

ideopunk
Copy link

This adds a config plugin to make the SDK compatible with Expo. The readme has been updated with steps for Expo users.

@erzaehlsalex
Copy link

We have to integrate this sdk in our expo app as well! Does this also work with iOS? I have taken a look at your changes and it only includes changes for Android? Or am I wrong?

@ideopunk
Copy link
Author

@erzaehlsalex When I ran expo prebuild, I found that my podfile platform was at v12, and that the android/build.gradle already contained mavenCentral(), so I decided to try just adding the multidex change to start. It worked fine on my ios and android, so here we are! I'd be curious to hear if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henribruvier henribruvier henribruvier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ideopunk @erzaehlsalex @henribruvier