Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user interaction to animation #252

Merged
merged 1 commit into from
Feb 27, 2016
Merged

Conversation

ivanbruel
Copy link
Contributor

When using Kingfisher with any type of animation, it was just breaking user interaction and not allowing users to scroll through lists on interact with the UIImageViews themselves.

This was mostly due to the fact that .AllowUserInteraction was not an option on the UIView.transitionWithView call.

@codecov-io
Copy link

Current coverage is 76.90%

Merging #252 into master will not affect coverage as of 8311f13

@@            master   #252   diff @@
=====================================
  Files           11     11       
  Stmts         1260   1260       
  Branches         0      0       
  Methods          0      0       
=====================================
  Hit            969    969       
  Partial          0      0       
  Missed         291    291       

Review entire Coverage Diff as of 8311f13

Powered by Codecov. Updated on successful CI builds.

onevcat added a commit that referenced this pull request Feb 27, 2016
Added user interaction to animation
@onevcat onevcat merged commit 107c445 into onevcat:master Feb 27, 2016
@onevcat
Copy link
Owner

onevcat commented Feb 27, 2016

@ivanbruel Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants