Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageCache.diskStorageSize #1997

Merged
merged 6 commits into from
Oct 11, 2022
Merged

ImageCache.diskStorageSize #1997

merged 6 commits into from
Oct 11, 2022

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for Kingfisher.
Continue with Concurrency.

@onevcat
Copy link
Owner

onevcat commented Oct 6, 2022

You can ignore the testing for now. It is a long-existing infra issue.

@RomanPodymov
Copy link
Contributor Author

@onevcat Hello, what should I fix in this pull request?

@onevcat
Copy link
Owner

onevcat commented Oct 11, 2022

@RomanPodymov

I just did not have enough time to take a look at it yet! Sorry for that.

Can you please just call calculateDiskStorageSize inside this async getter? I want to keep no duplication on this as possible, and in the future if we need to apply any change, we can make sure to just do it in one place.

@onevcat onevcat merged commit dffcc08 into onevcat:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants