Fix middleware app setting checks

[delano]

User description

A change has been made to how middleware checks for Otto app settings to determine if percent encoding and UTF-8 validation should be applied. Previously, the check returned true if the app had settings defined, but this allowed validation to be applied even if the specific setting was disabled. The changes now only return true if both the app has settings AND the relevant setting is explicitly enabled, avoiding unnecessary validation.

Include new AppSettings in web, colonel apps

---

PR Type

Bug fix, Enhancement

---

Description

• Fixed middleware checks for Otto app settings to ensure percent encoding and UTF-8 validation are only applied if the relevant settings are explicitly enabled.
• Included AppSettings module in both Colonel and Web apps.
• Added necessary require statements for base.rb in Colonel and Web apps.

---

Changes walkthrough 📝

	Relevant files
Bug fix	handle_invalid_percent_encoding.rb Fix middleware check for URI encoding settings                      lib/middleware/handle_invalid_percent_encoding.rb Modified the check_enabled? method to ensure that setting_enabled is only true if has_settings is true. Simplified the return statement to only check setting_enabled. +2/-2      handle_invalid_utf8.rb Fix middleware check for UTF-8 settings                                    lib/middleware/handle_invalid_utf8.rb Modified the check_enabled? method to ensure that setting_enabled is only true if has_settings is true. Simplified the return statement to only check setting_enabled. +2/-2
Enhancement	colonel.rb Include AppSettings in Colonel app                                              lib/onetime/app/colonel.rb Included AppSettings module in Colonel class. Added a require statement for base.rb. +2/-0      web.rb Include AppSettings in Web app                                                      lib/onetime/app/web.rb Included AppSettings module in Web class. Added a require statement for base.rb. +2/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Logic Change The logic change in check_enabled? method now correctly checks both if settings exist and if URI encoding is enabled. Ensure this change aligns with all intended use cases and doesn't affect other middleware functionalities. Logic Change Similar to the URI encoding check, the UTF-8 check logic has been modified to ensure settings are explicitly enabled. Validate that this change does not introduce any regressions or unintended behaviors in UTF-8 handling.

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Check if the method check_uri_encoding exists before calling it Ensure that the method check_uri_encoding exists and is accessible on route.klass before calling it to avoid potential NoMethodError if the method is not defined. lib/middleware/handle_invalid_percent_encoding.rb [83] -setting_enabled = has_settings && route.klass.check_uri_encoding +setting_enabled = has_settings && route.klass.respond_to?(:check_uri_encoding) && route.klass.check_uri_encoding Apply this suggestion Suggestion importance[1-10]: 9 Why: This suggestion prevents a potential NoMethodError by ensuring the method check_uri_encoding exists before calling it, which is a good practice for robust code.	9
	Check if the method check_utf8 exists before calling it Ensure that the method check_utf8 exists and is accessible on route.klass before calling it to avoid potential NoMethodError if the method is not defined. lib/middleware/handle_invalid_utf8.rb [88] -setting_enabled = has_settings && route.klass.check_utf8 +setting_enabled = has_settings && route.klass.respond_to?(:check_utf8) && route.klass.check_utf8 Apply this suggestion Suggestion importance[1-10]: 9 Why: This suggestion prevents a potential NoMethodError by ensuring the method check_utf8 exists before calling it, which is a good practice for robust code.	9
Possible issue	Conditionally include AppSettings if it is defined Ensure that the AppSettings module is defined and available before including it in the Colonel class to prevent NameError. lib/onetime/app/colonel.rb [6] -include AppSettings +include AppSettings if defined?(AppSettings) Apply this suggestion Suggestion importance[1-10]: 8 Why: This suggestion prevents a potential NameError by ensuring the AppSettings module is defined before including it, which enhances code stability.	8