Repository navigation
feat(terminal): show spinner on tabs with running child processes - #107
Merged
Merged
Conversation
Emit terminal-busy-{id} events from the existing CWD polling loop in
the Rust backend when a terminal's busy state changes. The frontend
subscribes to these events, stores busy state in a busyMap on the
terminal store, and TerminalTabLabel renders a spinning icon when the
terminal has an active child process.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal-busy-{id}events from the existing Rust CWD polling loop when a terminal's busy state changes (zero extra cost — reuses theget_child_pidcall already happening every 2s)busyMapon the terminal store, andTerminalTabLabelrenders a spinning icon when the terminal has an active child processTest plan
sleep 10) in one tab — its tab should show a spinnersleepfinishes, the spinner should disappear within ~2 secondsReview Notes
Deferred low/medium issues (no action needed):
busyMapentry if a stale busy event arrives after tab removal — single boolean, no visible side effectsisTerminalBusyIPC command (used by close-tab confirmation) could be replaced with a synchronousbusyMapread, but the 0-2s polling lag makes the IPC call more accurate for that use case🤖 Generated with Claude Code