Skip to content

Conversation

@vlaci
Copy link
Contributor

@vlaci vlaci commented Oct 9, 2024

No description provided.

@vlaci vlaci marked this pull request as ready for review October 9, 2024 20:38
László Vaskó added 4 commits October 9, 2024 23:40
Newer typeshed, contains stub for atheris.
…t module import

To sort this out, `unhex`` is moved to the already existing `testing`
module and imported from an explicit root package
Since PEP 688[^1], `bytes` is no longer an implicit base class of
`bytearray` and `memoryview`. The new `collections.abc.Buffer`
protocol implements all of them, but `bytes` and `bytearray` support
`__iter__` and `__len__` as well, so it is unsuitable for our case

[^1]: https://peps.python.org/pep-0688/
@qkaiser
Copy link
Contributor

qkaiser commented Oct 10, 2024

beat me to it ! I'll have a look :)

@qkaiser qkaiser self-requested a review October 10, 2024 14:27
Copy link
Contributor

@qkaiser qkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qkaiser qkaiser merged commit ffd590d into main Oct 10, 2024
15 checks passed
@qkaiser qkaiser deleted the python-313 branch October 10, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants