fix(yaffs): extend potential page size list to include 2032 bytes #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a sample we see a page_size with 2032 bytes and 16 bytes spare. Apparently the sum of page+spare is 2048 bytes. As we have many checks to see if a page_size is indeed valid and calculate also spare size, having an additional potential page size should not cause any problem. As page sizes are tested in the order specified, this new and unlikely case added to the end not to slow down other extractions.
martonilles
force-pushed
the
fix-yaffs2-page_size
branch
from
135e2b6 to
64b827e
Compare
e3krisztian
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
That sample is probably for a device with NOR-flash and inband tags.
Without further samples to support the above, and to provide a better understanding, this is the least intrusive fix we can do now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a sample we see a page_size with 2032 bytes and 16 bytes spare. Apparently the sum of page+spare is 2048 bytes.
As we have many checks to see if a page_size is indeed valid and calculate also spare size, having an additional potential page size should not cause any problem.
As page sizes are tested in the order specified, this new and unlikely case added to the end not to slow down other extractions.