lief: silence error log spam #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 0.15, the error logs got very chatty (search for `LIEF_ERR` in
its code base).
E.g. the following log appears tens of thousands of times for an
unsupported architecture:
LIEF does not support relocation for 'ARC_COMPACT'
There are no logs for `CRITICAL` level, so there is nothing much we
can do besides turning of logging.
kissgyorgy
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0.15, the error logs got very chatty (search for
LIEF_ERRin its code base).E.g. the following log appears tens of thousands of times for an unsupported architecture:
There are no logs for
CRITICALlevel, so there is nothing much we can do besides turning of logging.