chore(dissect.cstruct): Make Unblob compatible with version 4.0 #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlaci
changed the title
We cannot upgrade our requirement to 4.0, as it has no Python 3.8 support. The second best thing we can do is to relax the dependency specification and make our logging code compatible with both versions. This is the only place we depend on runtime types. Fixes: #888
vlaci
force-pushed
the
relax-dissect-cstruct-annotation
branch
from
057b1cd to
94f9129
Compare
e3krisztian
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot upgrade our requirement to 4.0, as it has no Python 3.8 support. The second-best thing we can do is to relax the dependency specification and make our logging code compatible with both versions. This is the only place we depend on runtime types.
In the next nix flake update, Nix builds will also use 4.0 version.
Fixes: #888