fix(zip): handle ZIP64 files missing indicators of ZIP64. #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyuware
approved these changes
Jun 10, 2024
e3krisztian
approved these changes
Jun 10, 2024
Sometimes large zip files created with 7z are missing indicators that they're ZIP64 (see is_zip64() implementation for details on heuristics we use to detect ZIP64). Since we can't rely on our heuristics, we simply fallback to ZIP64 if we can't find ZIP32 EOCDs.
qkaiser
force-pushed
the
fix-zip64-handler
branch
from
60069de to
7a7780d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes large zip files created with 7z are missing indicators that they're ZIP64 (see
is_zip64()implementation for details on heuristics we use to detect ZIP64).Since we can't rely on our heuristics, we simply fallback to ZIP64 if we can't find ZIP32 EOCDs.