fix(handler): introduce upper size limit for s_log_block_size #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyuware
force-pushed
the
s_log_block_size_fixup
branch
from
6936a27 to
eb1930f
Compare
qkaiser
force-pushed
the
s_log_block_size_fixup
branch
from
eb1930f to
c7a1efd
Compare
|
Makes perfect sense since |
qkaiser
added
enhancement
qkaiser
reviewed
Mar 4, 2024
nyuware
force-pushed
the
s_log_block_size_fixup
branch
2 times, most recently
from
5cf45a1 to
f57ce5c
Compare
qkaiser
force-pushed
the
s_log_block_size_fixup
branch
from
f57ce5c to
e5aa15e
Compare
qkaiser
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum block size limit on a 64bit system is
65536.When creating a fake filesystem with
mkfs.ext4and setting the block size with-b 65536, the maximum value thats_log_block_sizewill reach is6.Fixes : #792