fix(gzip): empty files are invalid and should not be parsed #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
fix_786
branch
2 times, most recently
from
0494262 to
01a9d8f
Compare
|
Thanks @AndrewFasano ! I took the liberty to work on your branch to also cover the sevenzip multi-volume handler and add some checks in the This is something that came up when I worked on fuzzing (see https://github.com/onekey-sec/unblob/blob/main/fuzzing/search_chunks_fuzzer.py#L50) but I left it on the side. Will request a review from the team. |
orosam
reviewed
Feb 27, 2024
…ty content. Creating a File from empty bytes or an empty file would lead to mmap raising an Exception so we check it ourselves and raise an InvalidInputFormat if that happens.
orosam
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an empty file into
File.from_pathleads to an error that an empty file cannot be mmaped.This could also be implemented in the from_path method, but I thought the
is_validmethod made since because an empty file isn't a valid gzip.Fixes #786