Skip to content

fix(handler): fix UBI PEB size calculation. #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(handler): fix UBI PEB size calculation. #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/test_iter_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
@pytest.mark.parametrize(
"values, expected",
[
([], set()),
([0, 0], {0}),
([0, 0, 0], {0}),
([1, 2, 3], {1}),
([1, 5, 8, 8, 10, 15], {4, 3, 0, 2, 5}),
([], []),
([0, 0], [0]),
([0, 0, 0], [0, 0]),
([1, 2, 3], [1, 1]),
([1, 5, 8, 8, 10, 15], [4, 3, 0, 2, 5]),
],
)
def test_get_internals(values, expected):
Expand Down
8 changes: 4 additions & 4 deletions unblob/iter_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import itertools
from typing import List, Set
from typing import List


def pairwise(iterable):
Expand All @@ -10,7 +10,7 @@ def pairwise(iterable):
return zip(a, b)


def get_intervals(values: List[int]) -> Set[int]:
def get_intervals(values: List[int]) -> List[int]:
"""Get all the intervals between numbers.

It's similar to numpy.diff function.
Expand All @@ -20,7 +20,7 @@ def get_intervals(values: List[int]) -> Set[int]:
>>> get_intervals([1, 4, 5, 6, 10])
[3, 1, 1, 4]
"""
all_diffs = set()
all_diffs = []
for value, next_value in pairwise(values):
all_diffs.add(next_value - value)
all_diffs.append(next_value - value)
return all_diffs