Drop python 3.8 support #1008
Merged
Drop python 3.8 support #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until we're ready to flip the switch. |
qkaiser
force-pushed
the
drop-python3.8
branch
2 times, most recently
from
169eeb0 to
ee4a2ca
Compare
qkaiser
force-pushed
the
drop-python3.8
branch
2 times, most recently
from
0bc041a to
07105bb
Compare
|
Once reviewed it can be merged. The support drop will reach end users only when we do a tagged release :) |
|
I replaced the required checks that was set to Python 3.8 tests to Python 3.9 tests in our repo config. |
qkaiser
added
documentation
qkaiser
force-pushed
the
drop-python3.8
branch
from
3d96754 to
fbd39b4
Compare
Python 3.8 reached EOL on 2024-10-07. Our dependencies will likely drop support for that version as well, so it will be a burden to keep-up support for it sooner or later.
Remove the cstruct dependency requirements relaxation introduced by 94f9129 to maintain Python 3.8 support. It's no longer needed so now we use cstruct version 4.0 and up.
We cannot use Path.readlink to check if the symlink target is
not set (that happens with f_badsymlinks.img on Darwin systems, you need
a broken filesystem and an OS that supports it).
That's because Path.readlink returns a Path object with an empty name
(i.e. Path("")), which is indiscernable from a symlink target that is
the current directory (i.e. Path(".")). Since there is no difference
between Path("") and Path("."), we can't differentiate between a symlink
with an empty target and a symlink that points at the current directory.
qkaiser
force-pushed
the
drop-python3.8
branch
from
fbd39b4 to
8c778cd
Compare
e3krisztian
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 reached EOL on 2024-10-07. Our dependencies will likely drop support for that version as well, so it will be a burden to keep-up support for it sooner or later.