Bug fix: gtag.event() syntax
#11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
gtagservice'sevent()method sends the event to thewindow.dataLayerwith incorrect syntax. This bug prevents GA4 from receiving any event sent viagtag.event().I noticed this bug first on my own, then saw it corroborated by @romgere in #8. This comment in that thread matches my experience, and my proposed solution.
Here's the syntax that should be used to send events, via the API documentation:
If accepted, this 1-line change will close #8 and make it possible to send events via this package. Best of all, the change doesn't break existing calls to
gtag.event(), it just makes those calls actually work.Thanks for making this available! I hope this contribution helps.