Editing Support #16
Merged
Editing Support #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 16, 2019 15:56
Keats
reviewed
Jan 21, 2020
Keats
approved these changes
Jan 22, 2020
| where | ||
| D: Debug + PartialOrd + Sum, | ||
| T: Clone + Debug + Display + Hash + PartialEq + Ord, | ||
| W: Clone + Debug + Ord + PartialOrd + PartialEq + Sum, |
There was a problem hiding this comment.
Looking forward to https://doc.rust-lang.org/unstable-book/language-features/trait-alias.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch to be merged as
v0.4and includes a number of reliability and feature improvements.Only minor breaking changes are expected for a potential
v1release (the Python__getitem__format is still TBD).New features:
addandremovemethods added toGeneralTaxonomyadd,removeandchangemethods added to Python APIBreaking API changes including:
crate::distancestocrate::weightsbase::GeneralTaxonomy::newtobase::GeneralTaxonomy::from_arraysbase::IntTaxIDtobase::IntTaxIdformats::json::load_json_fileformats::json::load_jsontakes a slice of &str instead of a period-delimited listNonereplaced with ranks ofTaxRank::Unspecifiedand many rank-related functions take/returnTaxRankinstead ofOption<TaxRank>for simplicityCloses #8, closes #9, closes #12, and closes #13.