Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msys2_installation.rb #iterate_msys_paths #361

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Update msys2_installation.rb #iterate_msys_paths #361

merged 1 commit into from
Jan 19, 2024

Conversation

dsisnero
Copy link
Contributor

prefer ENV["MSYS2_PATH"] if set for #iterate_msys_paths

prefer ENV["MSYS2_PATH"] if set for #iterate_msys_paths
@dsisnero
Copy link
Contributor Author

Can we get this merged?

@larskanis larskanis force-pushed the master branch 2 times, most recently from cf8c24b to ee56793 Compare December 26, 2023 10:31
@larskanis
Copy link
Member

Can you tell something about your use case? Why are the current options to find the MSYS2 directory not enough? For instance it's possible to add the MSYS2 directory to the PATH environment variable if it's in a uncommon location. You also can make a link into the ruby directory to the MSYS2 location.
To merge this we also need a test case.

@dsisnero
Copy link
Contributor Author

dsisnero commented Jan 8, 2024

I don't want to have MYS2 under PATH environment variable because I don't want to use any of those executables unless I specifically ridk enable - or open amys2 or mingw shell.

I don't default to c:\msys2 because I need to install it on a work computer with limited space in c drive, This computer is locked down for most users so they don't have the capability to create drive junctions , (symlinks) and limited functionality. For me, I install it in a separate usb c drive - e:\msys2 and it is easiest to set an ENVIRONMENT variable for this rather then symlink. I would just tell people who installed ruby open command prompt and type setx MSYS2_PATH e:\msys2 or to whatever drive they have mapped and they won't have to get admin privileges to enable creating symlinks

@larskanis larskanis merged commit fae67ee into oneclick:master Jan 19, 2024
8 of 10 checks passed
larskanis added a commit that referenced this pull request Jan 19, 2024
Introduced in commit a4590dd of PR #361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants