Skip to content

[fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition#25

Closed
oneby-wang wants to merge 2 commits intomasterfrom
async_delete_lose_mark_delete_properties
Closed

[fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition#25
oneby-wang wants to merge 2 commits intomasterfrom
async_delete_lose_mark_delete_properties

Conversation

@oneby-wang
Copy link
Owner

@oneby-wang oneby-wang commented Jan 20, 2026

Motivation

ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition.

Modifications

  1. Add testAsyncDeleteNeverLoseMarkDeleteProperties() test to reproduce the issue.
  2. Pass null to internalAsyncMarkDelete() method's properties param in asyncDelete() method.
  3. Run test to verify the code change.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant