emit error when publishFn err Channel closed #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cressie176
approved these changes
Mar 6, 2020
|
published as rascal@8.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when pool.acquire() success but connection is at error state (at same time network is broken),
PublicationtrypublishFnwill throw errIllegalOperationError {message: "Channel closed", stack: "IllegalOperationError: Channel closed\n at Confi…", stackAtStateChange: "Stack capture: Socket error\n at Connection.onSo…"}and be catched , but not emit error event for user to known this, it may lead to message loss !