Skip to content

[ur] Enable better formating for tests #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

veselypeta
Copy link
Contributor

@veselypeta veselypeta commented Mar 8, 2023

This PR:

  • Removes ColumnLimit: 0 from the root .clang-format.
  • Adds override .clang-format file for autogenerated files in /include
  • Applies all remaining formating changes

Important files .clang-format include/.clang-format

@veselypeta veselypeta marked this pull request as draft March 8, 2023 14:07
@pbalcer
Copy link
Contributor

pbalcer commented Mar 8, 2023

Hm, to be more consistent across the codebase, perhaps we could create a .clang-format in the include directory with ColumnLimit: 0, and then remove that setting from the .clang-format in the main directory?

@kbenzie
Copy link
Contributor

kbenzie commented Mar 8, 2023

Hm, to be more consistent across the codebase, perhaps we could create a .clang-format in the include directory with ColumnLimit: 0, and then remove that setting from the .clang-format in the main directory?

This thought has been hanging around in the back of my mind too. I've found it harder to review non-generated code recently with the unlimited line lengths.

@veselypeta veselypeta marked this pull request as ready for review March 15, 2023 09:43
@veselypeta veselypeta requested a review from pbalcer March 15, 2023 10:51
@pbalcer
Copy link
Contributor

pbalcer commented Mar 15, 2023

Everyone needs to rebase PRs after this is merged.

@pbalcer pbalcer merged commit d6af758 into oneapi-src:main Mar 15, 2023
@veselypeta veselypeta deleted the petr/format-tests branch March 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants