Skip to content

[L0][CMDBUF] Optimize fence/event waits during update #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

[L0][CMDBUF] Optimize fence/event waits during update #2561

merged 1 commit into from
Jan 17, 2025

Conversation

@Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Jan 14, 2025

  • Track whether a command buffer was recently synchronized so we can skip unnecessary fence/event waits. Previous consecutive calls to update a command buffer would result in calling zeFenceHostSynchronize for each call unnecessarily.

@Bensuo Bensuo requested a review from a team as a code owner January 14, 2025 16:46
@Bensuo Bensuo requested a review from EwanC January 14, 2025 16:46
@Bensuo
Copy link
Contributor Author

Bensuo commented Jan 14, 2025

DPC++ PR: intel/llvm#16629

@github-actions github-actions bot added level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Jan 14, 2025
EwanC
EwanC approved these changes Jan 14, 2025
View reviewed changes
@Bensuo Bensuo force-pushed the ben/cmd-buffer-l0-fence branch from 5b41da0 to fe926aa Compare January 14, 2025 17:17
@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Jan 15, 2025
@Bensuo
[L0][CMDBUF] Optimize fence/event waits during update
28108a7 
- Track whether a command buffer was recently synchronized so we can skip unnecessary fence/event waits
@Bensuo Bensuo force-pushed the ben/cmd-buffer-l0-fence branch from fe926aa to 28108a7 Compare January 16, 2025 15:06
@kbenzie kbenzie merged commit 222e4b1 into oneapi-src:main Jan 17, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EwanC EwanC EwanC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

command-buffer Command Buffer feature addition/changes/specification level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bensuo @EwanC @kbenzie