Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add "loader" support to conformance testing #2082

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RossBrunton
Copy link
Contributor

@RossBrunton RossBrunton commented Sep 11, 2024

This expands our CI to test the loader; the dispatcher that is
used when multiple adapters are availabe.

Previously, the unit tests forced a specific adapter, via
UR_ADAPTERS_FORCE_LOAD. Now an extra "loader" target is created
for each test suite, which doesn't set that variable and allows
the loader to be used.

In addition, the test runner's adapter selection logic has been
rewritten to support a "--backend" variable, which allows you to
select a backend (OpenCL, Level Zero, etc.).

The platform selection has also been expanded to support
filtering by a backend to match that platform only on that backend
(e.g. UR_CTS_ADAPTER_PLATFORM="opencl:Fictional Corp(R)").

The old "run on hardware" jobs should behave the same (they have
the loader tests disabled), but there is a new
combined-opencl-level-zero job that tests a build with both
OpenCL and Level Zero available.

Closes: #2081

@github-actions github-actions bot added the loader Loader related feature/bug label Sep 11, 2024
@github-actions github-actions bot added the ci/cd Continuous integration/devliery label Sep 12, 2024
@RossBrunton RossBrunton force-pushed the ross/multiadapt branch 3 times, most recently from 765d74d to 1a590df Compare September 26, 2024 14:25
@github-actions github-actions bot added the conformance Conformance test suite issues. label Sep 26, 2024
@RossBrunton RossBrunton force-pushed the ross/multiadapt branch 7 times, most recently from 43feaa2 to 6b30976 Compare September 30, 2024 10:26
@RossBrunton RossBrunton changed the title [DO NOT MERGE] Testing for multiple adapters [CI] Add "loader" support to conformance testing Sep 30, 2024
@RossBrunton RossBrunton force-pushed the ross/multiadapt branch 9 times, most recently from 23ec456 to c26d47e Compare October 2, 2024 16:05
@github-actions github-actions bot added the specification Changes or additions to the specification label Oct 9, 2024
@RossBrunton RossBrunton force-pushed the ross/multiadapt branch 2 times, most recently from 7013ef0 to 1c51ebc Compare October 10, 2024 14:50
This expands our CI to test the loader; the dispatcher that is
used when multiple adapters are availabe.

The old "run on hardware" jobs should behave the same (they have
the loader tests disabled), but there is a new
`combined-opencl-level-zero` job that tests a build with both
OpenCL and Level Zero available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration/devliery conformance Conformance test suite issues. loader Loader related feature/bug specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI testing for builds with multiple adapters
1 participant