-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Loader] Suppress system errors when loading adapters on Windows #2060
Merged
omarahmed1111
merged 2 commits into
oneapi-src:main
from
martygrant:martin/supressSystemErrorsOnWindows
Sep 16, 2024
Merged
[Loader] Suppress system errors when loading adapters on Windows #2060
omarahmed1111
merged 2 commits into
oneapi-src:main
from
martygrant:martin/supressSystemErrorsOnWindows
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
martin/supressSystemErrorsOnWindows
branch
from
September 9, 2024 11:00
106fa9a
to
4db3c1f
Compare
pbalcer
approved these changes
Sep 9, 2024
aarongreig
requested changes
Sep 11, 2024
nrspruit
approved these changes
Sep 11, 2024
aarongreig
approved these changes
Sep 12, 2024
martygrant
force-pushed
the
martin/supressSystemErrorsOnWindows
branch
from
September 13, 2024 13:38
34ec5a4
to
d7ac3dd
Compare
Co-authored-by: aarongreig <aaron.greig@codeplay.com>
martygrant
changed the title
[Loader] Supress system errors when loading adapters on Windows
[Loader] Suppress system errors when loading adapters on Windows
Sep 13, 2024
omarahmed1111
added a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 16, 2024
…emErrorsOnWindows [Loader] Suppress system errors when loading adapters on Windows
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
loader
Loader related feature/bug
ready to merge
Added to PR's which are ready to merge
v0.10.x
Include in the v0.10.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aarongreig
Disables system errors when loading adapters on Windows, and re-enables them after.
intel/llvm#15388