-
Notifications
You must be signed in to change notification settings - Fork 124
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Sep 4, 2024
- Added Prefilter which uses ONEAPI_DEVICE_SELECTOR to remove backends that the user has not requested.
- this handles both the "Accept" or "Discard" filters that can be set in the ONEAPI_DEVICE_SELECTOR.
- Added tests verify the Accept/Discard use cases on Linux.
- Added UR_LOADER_PRELOAD_FILTER to toggle the prefilter on and off.
e3f680a to
a54ccbd
Compare
a54ccbd to
6f63c0e
Compare
6f63c0e to
09713cc
Compare
32f6102 to
7005cc5
Compare
pbalcer
approved these changes
Sep 5, 2024
Contributor
pbalcer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a few nits.
7005cc5 to
7bf0384
Compare
pbalcer
approved these changes
Sep 5, 2024
Contributor
|
L0 e2e fails with: However, the exact same of tests are failing on main: So seems unrelated. |
igchor
reviewed
Sep 5, 2024
igchor
approved these changes
Sep 5, 2024
7bf0384 to
6e22aad
Compare
- Added Prefilter which uses ONEAPI_DEVICE_SELECTOR to remove backends that the user has not requested. - this handles both the "Accept" or "Discard" filters that can be set in the ONEAPI_DEVICE_SELECTOR. - Added tests verify the Accept/Discard use cases on Linux. - Added UR_LOADER_PRELOAD_FILTER to toggle the prefilter on and off. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
6e22aad to
2fcf3bf
Compare
Contributor
|
I'll merge once CI completes. |
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 5, 2024
…ackends -pre-commit PR for oneapi-src/unified-runtime#2053 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 6, 2024
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 9, 2024
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends
igchor
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 9, 2024
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
loader
Loader related feature/bug
ready to merge
Added to PR's which are ready to merge
specification
Changes or additions to the specification
v0.10.x
Include in the v0.10.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.