Skip to content

Conversation

@nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Sep 4, 2024

  • Added Prefilter which uses ONEAPI_DEVICE_SELECTOR to remove backends that the user has not requested.
  • this handles both the "Accept" or "Discard" filters that can be set in the ONEAPI_DEVICE_SELECTOR.
  • Added tests verify the Accept/Discard use cases on Linux.
  • Added UR_LOADER_PRELOAD_FILTER to toggle the prefilter on and off.

@nrspruit nrspruit requested a review from a team as a code owner September 4, 2024 22:04
@nrspruit nrspruit force-pushed the ur_loader_prefilter branch from e3f680a to a54ccbd Compare September 4, 2024 22:06
@github-actions github-actions bot added the loader Loader related feature/bug label Sep 4, 2024
@nrspruit nrspruit force-pushed the ur_loader_prefilter branch from a54ccbd to 6f63c0e Compare September 4, 2024 22:12
@nrspruit nrspruit marked this pull request as draft September 4, 2024 22:18
@nrspruit nrspruit force-pushed the ur_loader_prefilter branch from 6f63c0e to 09713cc Compare September 4, 2024 23:03
@nrspruit nrspruit marked this pull request as ready for review September 4, 2024 23:12
@nrspruit nrspruit force-pushed the ur_loader_prefilter branch 2 times, most recently from 32f6102 to 7005cc5 Compare September 4, 2024 23:42
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few nits.

@nrspruit nrspruit force-pushed the ur_loader_prefilter branch from 7005cc5 to 7bf0384 Compare September 5, 2024 16:00
@github-actions github-actions bot added the specification Changes or additions to the specification label Sep 5, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Sep 5, 2024

L0 e2e fails with:

  SYCL :: Basic/accessor/accessor.cpp
  SYCL :: DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
  SYCL :: ESIMD/grf.cpp
  SYCL :: Graph/Explicit/interop-level-zero-launch-kernel.cpp
  SYCL :: Graph/RecordReplay/interop-level-zero-launch-kernel.cpp
  SYCL :: syclcompat/launch/launch_policy_lmem.cpp

However, the exact same of tests are failing on main:

  SYCL :: Basic/accessor/accessor.cpp
  SYCL :: DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
  SYCL :: ESIMD/grf.cpp
  SYCL :: Graph/Explicit/interop-level-zero-launch-kernel.cpp
  SYCL :: Graph/RecordReplay/interop-level-zero-launch-kernel.cpp
  SYCL :: syclcompat/launch/launch_policy_lmem.cpp

So seems unrelated.

@nrspruit nrspruit force-pushed the ur_loader_prefilter branch from 7bf0384 to 6e22aad Compare September 5, 2024 17:16
- Added Prefilter which uses ONEAPI_DEVICE_SELECTOR to remove backends
  that the user has not requested.
- this handles both the "Accept" or "Discard" filters that can be set in
  the ONEAPI_DEVICE_SELECTOR.
- Added tests verify the Accept/Discard use cases on Linux.
- Added UR_LOADER_PRELOAD_FILTER to toggle the prefilter on and off.

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit force-pushed the ur_loader_prefilter branch from 6e22aad to 2fcf3bf Compare September 5, 2024 17:18
@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Sep 5, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Sep 5, 2024

I'll merge once CI completes.

nrspruit added a commit to nrspruit/llvm that referenced this pull request Sep 5, 2024
…ackends

-pre-commit PR for oneapi-src/unified-runtime#2053

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit added the v0.10.x Include in the v0.10.x release label Sep 5, 2024
@pbalcer pbalcer merged commit 70e85f2 into oneapi-src:main Sep 6, 2024
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Sep 6, 2024
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Sep 9, 2024
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends
igchor pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Sep 9, 2024
[LOADER] Added Prefilter using ONEAPI_DEVICE_SELECTOR to remove backends
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loader Loader related feature/bug ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification v0.10.x Include in the v0.10.x release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants