Remove command-buffer CTS L0 workaround #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CTS code for command-buffers on the L0 backend has a workaround that forces batched submission to be used rather than immediate submission. However, both batch and immediate submission L0 command-lists are now supported, so this workaround is no longer required. Tested by running on PVC which uses immediate command-lists by default.
fabiomestre
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTS code for command-buffers on the L0 backend has a workaround that forces batched submission to be used rather than immediate submission.
However, both batch and immediate submission L0 command-lists are now supported, so this workaround is no longer required.
Tested by running on PVC which uses immediate command-lists by default. Also by manually setting env var
UR_L0_USE_IMMEDIATE_COMMANDLISTSto both1and0when running the CTS tests.