[OpenCL] Fix USM alignment error check to occur always and return nulllptr #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Aug 26, 2024
nrspruit
commented
- USM calls to alloc must return a nullptr and error given invalid alignment. This cannot be relied upon in the validation layer.
nrspruit
force-pushed
the
fix_opencl_usm_align_check
branch
3 times, most recently
from
658c0a8 to
be90943
Compare
…lptr - USM calls to alloc must return a nullptr and error given invalid alignment. This cannot be relied upon in the validation layer. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
kbenzie
force-pushed
the
fix_opencl_usm_align_check
branch
from
be90943 to
c3c5728
Compare
kbenzie
approved these changes
Aug 27, 2024
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 10, 2024
…_check [OpenCL] Fix USM alignment error check to occur always and return nulllptr
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 12, 2024
…_check [OpenCL] Fix USM alignment error check to occur always and return nulllptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.