Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeviceSanitizer] Support data migration for memory buffer #1864

Merged
merged 5 commits into from
Aug 20, 2024
Merged

[DeviceSanitizer] Support data migration for memory buffer #1864

merged 5 commits into from
Aug 20, 2024

Conversation

zhaomaosu
Copy link
Contributor

@zhaomaosu zhaomaosu commented Jul 16, 2024 •
edited
Loading

SYCLOS Part for pre-ci: intel/llvm#14578

@zhaomaosu zhaomaosu requested a review from a team as a code owner July 16, 2024 06:22
@github-actions github-actions bot added loader Loader related feature/bug sanitizer Sanitizer layer issues/changes/specification labels Jul 16, 2024
@zhaomaosu zhaomaosu mentioned this pull request Jul 16, 2024
Closed
yingcong-wu
yingcong-wu reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the buffer relative api would be call in multithreaded cases? Should we consider thread safety?

@zhaomaosu
Copy link
Contributor Author

I wonder if the buffer relative api would be call in multithreaded cases? Should we consider thread safety?

You are right. We need to make sure relative api is thread safe. Updated with latest commit.

@zhaomaosu
Copy link
Contributor Author

Hi @oneapi-src/unified-runtime-maintain, could you please help review this PR? We need this bug fix PR in v0.10.0rc release branch. Thanks.

@zhaomaosu
Copy link
Contributor Author

Hi @oneapi-src/unified-runtime-maintain, could you please help review this PR? We need this bug fix PR in v0.10.0rc release branch. Thanks.

Kindly ping @oneapi-src/unified-runtime-maintain

@aarongreig aarongreig added ready to merge Added to PR's which are ready to merge v0.10.x Include in the v0.10.x release labels Aug 20, 2024
@omarahmed1111 omarahmed1111 merged commit 3296886 into oneapi-src:main Aug 20, 2024
71 of 72 checks passed
kbenzie pushed a commit that referenced this pull request Aug 20, 2024
@omarahmed1111 @kbenzie
Merge pull request #1864 from zhaomaosu/buffer-migration
9535f74 
[DeviceSanitizer] Support data migration for memory buffer
@kbenzie kbenzie mentioned this pull request Aug 20, 2024
Merged
53 tasks
@omarahmed1111 omarahmed1111 mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZyne AllanZyne AllanZyne approved these changes

@aarongreig aarongreig aarongreig approved these changes

@yingcong-wu yingcong-wu yingcong-wu approved these changes

@jinge90 jinge90 Awaiting requested review from jinge90

Assignees
No one assigned
Labels
loader Loader related feature/bug ready to merge Added to PR's which are ready to merge sanitizer Sanitizer layer issues/changes/specification v0.10.x Include in the v0.10.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhaomaosu @AllanZyne @aarongreig @yingcong-wu @omarahmed1111