Remove the power of 2 pattern size requirement from USMFill #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All adapters have sufficiently robust workarounds that this is no longer necessary, and the sycl runtime is now using USMFill in such a way that if we enable the validation layer this case will get hit and break stuff.
github-actions
bot
added
loader
EwanC
reviewed
Jul 10, 2024
|
Does this fix #1837? |
no it fixes some new e2e regression on the port branch |
github-actions
bot
added
experimental
kbenzie
approved these changes
Jul 10, 2024
EwanC
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All adapters have sufficiently robust workarounds that this is no longer necessary, and the sycl runtime is now using USMFill in such a way that if we enable the validation layer this case will get hit and break stuff.