Skip to content

Correct mapping of BUFFER_ALLOC_LOCATION_PROPERITES in CL adapter. #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aarongreig
Copy link
Contributor

This should have been mapped to CL_MEM_ALLOC_BUFFER_LOCATION_INTEL.

This should have been mapped to CL_MEM_ALLOC_BUFFER_LOCATION_INTEL.
@codecov-commenter
Copy link

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (78ef1ca) 14.82% compared to head (b3469f1) 12.72%.
Report is 13 commits behind head on main.

Files Patch % Lines
...e/common/umf_pools/disjoint_pool_config_parser.cpp 0.00% 15 Missing ⚠️
source/common/umf_helpers.hpp 0.00% 9 Missing ⚠️
source/common/logger/ur_logger_details.hpp 61.53% 5 Missing ⚠️
test/usm/usmPoolManager.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
- Coverage   14.82%   12.72%   -2.10%     
==========================================
  Files         250      238      -12     
  Lines       36220    35338     -882     
  Branches     4094     4010      -84     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    30836      +36     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarongreig aarongreig marked this pull request as ready for review February 15, 2024 10:30
@aarongreig aarongreig requested a review from a team as a code owner February 15, 2024 10:30
@aarongreig
Copy link
Contributor Author

LLVM testing intel/llvm#12725

@kbenzie kbenzie merged commit 69ac6c7 into oneapi-src:main Feb 15, 2024
aarongreig pushed a commit to aarongreig/unified-runtime that referenced this pull request Feb 15, 2024
…BufferLocation

Correct mapping of BUFFER_ALLOC_LOCATION_PROPERITES in CL adapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants