Skip to content

Fix urEnqueueKernelLaunchTest.InvalidKernelArgs for CUDA backend #2720

Open
@RossBrunton

Description

@RossBrunton

intel/llvm#17068 changed the semantics for urEnqueueKernelLaunch to make validation optional; Implementations may return either INVALID_ARGS or SUCCESS if the arguments are wrong.

However, the Cuda backend in the InvalidKernelArgs test returns UR_RESULT_ERROR_INVALID_VALUE. This is because cuLaunchKernel returns CUDA_ERROR_INVALID_VALUE for the (incorrect) values in the test.

The implementation of urEnqueueKernelLaunch should be updated to either return INVALID_ARGS or SUCCESS. Note that validation is optional, so if the CUDA driver is unable to perform the validation, it is allowed to report a success even if the args are invalid.

Metadata

Metadata

Assignees

No one assigned

    Labels

    conformanceConformance test suite issues.cudaCUDA adapter specific issues

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions