unify return values for destroy functions #1356
Open
+223
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Jun 5, 2025
bratpiorka
reviewed
Jun 5, 2025
bratpiorka
reviewed
Jun 5, 2025
bratpiorka
reviewed
Jun 5, 2025
lplewa
force-pushed
the
unify
branch
4 times, most recently
from
5d2f404 to
941f998
Compare
bratpiorka
approved these changes
Jun 10, 2025
| @@ -48,7 +48,7 @@ typedef struct umf_memory_pool_ops_t { | |||
| /// @brief Finalizes memory pool | |||
| /// @param pool pool to finalize | |||
| /// | |||
There was a problem hiding this comment.
missing @return..?
| @@ -43,7 +43,7 @@ typedef struct umf_memory_provider_ops_t { | |||
| /// @brief Finalizes memory provider. | |||
| /// @param provider provider to finalize | |||
| /// | |||
There was a problem hiding this comment.
missing @return..?
| @@ -48,8 +48,11 @@ void test_disjoint_pool_shared_limits(void) { | |||
|
|
|||
| umfPoolDestroy(pool); | |||
| umfMemoryProviderDestroy(provider); | |||
There was a problem hiding this comment.
soo... should we add a return value check in all tests for all destroy calls...?
// I can see you added in some/most tests, but not in all of them
There was a problem hiding this comment.
Too much work, and almost zero gain to add it everywhere - i added few asserts for all changes function to ensure that return value is correct.
| } | ||
|
|
||
| if (!hProvider) { | ||
| return UMF_RESULT_SUCCESS; |
There was a problem hiding this comment.
I think we might be missing a test for that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1217
Description
Checklist