Fix build error if defined _WIN32_WINNT

[phprus]

Description

Fix build error if defined _WIN32_WINNT

Fixes #565, #627, #628

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add respective label(s) to PR if you have permissions

• bug fix - change which fixes an issue
• new feature - change which adds functionality
• tests - change in tests
• infrastructure - change in infrastructure and CI
• documentation - documentation update

Tests

• added - required for new features and for some bug fixes
• not needed

Documentation

• updated in # - add PR number
• needs to be updated
• not needed

Breaks backward compatibility

• Yes
• No
• Unknown

Notify the following users

@anton-potapov

Other information

[alexey-katranov]

Can you please show what exactly fails? Perhaps, it is not good testing strategy to define macros that users might not define.

[phprus]

Are you talking about NOMINMAX?
Without NOMINMAX, the macro max() are defined in windows.h.

This macro breaks the code:

oneTBB/test/common/doctest.h

Lines 5906 to 5908 in 6fad698

	auto totwidth = int(std::ceil(log10((std::max(p.numTestCasesPassingFilters, static_cast<unsigned>(p.numAsserts))) + 1)));
	auto passwidth = int(std::ceil(log10((std::max(p.numTestCasesPassingFilters - p.numTestCasesFailed, static_cast<unsigned>(p.numAsserts - p.numAssertsFailed))) + 1)));
	auto failwidth = int(std::ceil(log10((std::max(p.numTestCasesFailed, static_cast<unsigned>(p.numAssertsFailed))) + 1)));

I can fix doctest.h or add undef for the macros max and min after #include <dbghelp.h>

Adding a test for a defined _WIN32_WINNT will require adding a new task to CI.

[alexey-katranov]

doctest.h already defines NOMINMAX but it is too late because of the order of includes,. Your patch seems the lesser of evils (at least not to refactor without any purpose).

[phprus]

I think maybe replace

#define NOMINMAX

to

#ifndef NOMINMAX
#define NOMINMAX
#endif

in my patch?

[alexey-katranov]

It is not critical user observable code, so if the both approaches work, it is up to you what to choose.

[phprus]

Added #ifndef.

[anton-potapov]

LGTM