Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src : cpu : aarch64 : Jit_sve_conv_kernel #2229

Closed
wants to merge 1 commit into from

Conversation

nikhilfujitsu
Copy link
Contributor

@nikhilfujitsu nikhilfujitsu commented Nov 26, 2024

Description

ldr_imm_check function feature is utilized to improve the readability of code. This feature was already present in the code but not utilized in some part of the code.

Checklist

make test

    Start   1: cpu-bnorm-u8-via-binary-postops-cpp

1/218 Test #1: cpu-bnorm-u8-via-binary-postops-cpp ..................... Passed 0.08 sec
Start 2: cpu-cnn-inference-f32-c
2/218 Test #2: cpu-cnn-inference-f32-c ................................. Passed 0.07 sec
Start 3: cpu-cnn-inference-f32-cpp
.....
190/218 Test #190: test_benchdnn_modeC_binary_ci_cpu ....................... Passed 1.64 sec
Start 191: test_benchdnn_modeC_binary_different_dt_ci_cpu
191/218 Test #191: test_benchdnn_modeC_binary_different_dt_ci_cpu .......... Passed 3.07 sec
Start 192: test_benchdnn_modeC_bnorm_ci_cpu
192/218 Test #192: test_benchdnn_modeC_bnorm_ci_cpu ........................ Passed 2.84 sec
Start 193: test_benchdnn_modeC_brgemm_ci_cpu
193/218 Test #193: test_benchdnn_modeC_brgemm_ci_cpu ....................... Passed 1.73 sec
Start 194: test_benchdnn_modeC_concat_ci_cpu
194/218 Test #194: test_benchdnn_modeC_concat_ci_cpu ....................... Passed 1.54 sec
Start 195: test_benchdnn_modeC_conv_ci_cpu
195/218 Test #195: test_benchdnn_modeC_conv_ci_cpu ......................... Passed 64.63 sec
Start 196: test_benchdnn_modeC_deconv_ci_cpu
196/218 Test #196: test_benchdnn_modeC_deconv_ci_cpu ....................... Passed 16.88 sec
.....
217/218 Test #217: test_benchdnn_modeC_zeropad_ci_cpu ...................... Passed 38.44 sec
Start 218: noexcept-cpp
218/218 Test #218: noexcept-cpp ............................................ Passed 0.02 sec

99% tests passed, 2 tests failed out of 218

Total Test time (real) = 762.67 sec

The following tests FAILED:
167 - test_graph_unit_dnnl_large_partition_cpu (Failed)
199 - test_benchdnn_modeC_graph_ci_cpu (Failed)
Errors while running CTest
Output from these tests are in: /home/nikhil/oneDNN/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
make: *** [Makefile:71: test] Error 8

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit? YES.
  • Have you formatted the code using clang-format? YES.

@nikhilfujitsu nikhilfujitsu marked this pull request as ready for review November 26, 2024 22:56
@nikhilfujitsu nikhilfujitsu requested a review from a team as a code owner November 26, 2024 22:56
@nikhilfujitsu nikhilfujitsu deleted the ldr_imm_check branch November 26, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant